Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement generalised PaleyII symmetric conference matrices #38486

Merged
merged 5 commits into from
Sep 29, 2024

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Aug 8, 2024

Currently only symmetric conference matrices obtained from $GF(q)$ using Paley construction for $q\equiv 1\mod 4$
are used in building Hadamard matrices by PaleyII construction. But we can do better, use
any symmetric conference matrix known to Sage.

The 1st new to Sage example is of order 4*787

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@dimpase dimpase marked this pull request as draft August 8, 2024 13:07
@dimpase dimpase requested a review from MatteoCati August 8, 2024 13:07
Copy link

github-actions bot commented Aug 8, 2024

Documentation preview for this PR (built with commit 4d56220; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase
Copy link
Member Author

dimpase commented Aug 30, 2024

@MatteoCati - have you got around to look into this? If not, I can finish this myself.

@MatteoCati
Copy link
Contributor

I've created a PR to add the code to this branch dimpase#7 since I could not edit the branch directly.
I (incorrectly) assumed you would have received a notification about it.

@dimpase dimpase force-pushed the gen_paleyII_confmat branch 2 times, most recently from 16e610f to 1d41466 Compare September 2, 2024 14:02
@dimpase dimpase marked this pull request as ready for review September 2, 2024 16:11
@dimpase
Copy link
Member Author

dimpase commented Sep 2, 2024

Build documentation failure is a red herring, it seems.

@MatteoCati - ready for review

@dimpase
Copy link
Member Author

dimpase commented Sep 2, 2024

@kwankyu - do you have an idea why CI docbuild fails here (at the place where html docs update is handled by git merge
(or maybe git stash) ? It looks like a bug in the CI.

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 2, 2024

Yes. The blocker fixes the bug in ci: #38468

You may merge the PR to build doc preview.

The blocker has been slumbering there for at least three weeks. That is why I am suggesting this: https://groups.google.com/g/sage-devel/c/ad9hQZw1PKQ

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 27, 2024

Otherwise lgtm.

@dimpase
Copy link
Member Author

dimpase commented Sep 27, 2024

Thanks, I've fixed one of the things you pointed out. As to various .'s, it would need to be done consistently, through the codebase - where these vary.

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 27, 2024

I think you can set this to "positive review" since @MatteoCati implicitly acknowledged it.

@dimpase
Copy link
Member Author

dimpase commented Sep 27, 2024

Thanks!

@vbraun vbraun merged commit 944c01b into sagemath:develop Sep 29, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants