-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement generalised PaleyII symmetric conference matrices #38486
Conversation
Documentation preview for this PR (built with commit 4d56220; changes) is ready! 🎉 |
1595722
to
4dbecd8
Compare
@MatteoCati - have you got around to look into this? If not, I can finish this myself. |
I've created a PR to add the code to this branch dimpase#7 since I could not edit the branch directly. |
16e610f
to
1d41466
Compare
Build documentation failure is a red herring, it seems. @MatteoCati - ready for review |
@kwankyu - do you have an idea why CI docbuild fails here (at the place where html docs update is handled by |
Yes. The blocker fixes the bug in ci: #38468 You may merge the PR to build doc preview. The blocker has been slumbering there for at least three weeks. That is why I am suggesting this: https://groups.google.com/g/sage-devel/c/ad9hQZw1PKQ |
1d41466
to
35bf592
Compare
35bf592
to
6878c51
Compare
Otherwise lgtm. |
Thanks, I've fixed one of the things you pointed out. As to various |
I think you can set this to "positive review" since @MatteoCati implicitly acknowledged it. |
Thanks! |
Currently only symmetric conference matrices obtained from$GF(q)$ using Paley construction for $q\equiv 1\mod 4$
are used in building Hadamard matrices by PaleyII construction. But we can do better, use
any symmetric conference matrix known to Sage.
The 1st new to Sage example is of order 4*787
📝 Checklist